feat: discard queued tasks if running them as microtasks isn't supported #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only effect of this would be that browsers that do not support Promises or MutationObserver (currently mainly IE < 11 and Opera mini) would not cause a JS error. Values are not provided by these browsers with or without this fix. Could anybody please review this? |
added 2 commits
September 4, 2019 12:09
Since we use basic Map features (get, set, has, delete) only, we can as well just replace our maps by objects to support IE < 11 and other browser that do not recognize ES6 specifications. This keeps the bundle small and avoids the need of costy polyfills.
This reverts commit 7aeb05c.
Zizzamia
approved these changes
Sep 15, 2019
|
The code has been published under v3.0.0-beta.0 Please let me know if works all good! Also, v3 is going to have some nice extra feature, but before the full roll-out, I'm going to have a couple of extra betas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use perfume but have to support IE < 11 :(
I would prefer to discard measurements from that small user group (in the case measurement tasks got delayed until unloading of page) instead of integrating mutation-observer polyfill for all our users to support measurement for IE < 11.
I'm not the greatest event loop / microtask expert, so if there is a possibility to get measurement tasks handled on unloading of a page without promises and MutationObserver in place please give me a hint or feel free to supplement.