fix: 'PerformanceObserver is undefined' on Edge #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edge exposes `window.chrome` with a single `app` property, meaning that using `Boolean(window.chrome)` to test for the browser being chrome alone is not enough.
|
@Zizzamia can you review? |
|
Amazing, coming up soon with v0.8.0 Grazie Mille 🙏 |
|
🙌 Woo, thanks! |
|
@michaeldfallen released Perfume.js v0.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge exposes
window.chrome, meaning that usingBoolean(window.chrome)to test for the browser being chrome alone is not enough.To fix this I've also tested for the existence of PerformanceObserver on window so that we only try to use PerformanceObserver if it is defined.