fix: adjusted tests (#225)

Cdub-9 · web-flow · commit 105f26c3b991 · 2023-02-24T14:26:39.000-08:00
diff --git a/__tests__/steps/measureStep.spec.ts b/__tests__/steps/measureStep.spec.ts
@@ -116,7 +116,7 @@ describe('measureStep', () => {
         {
           detail: {
             duration: 100,
-            type: 'userJourneyStepVital',
+            type: 'stepVital',
           },
           end: 100,
           start: 100,
@@ -131,7 +131,7 @@ describe('measureStep', () => {
         navigationType: undefined,
         navigatorInformation: {
           deviceMemory: 0,
-          hardwareConcurrency: 8,
+          hardwareConcurrency: 12,
           isLowEndDevice: false,
           isLowEndExperience: false,
           serviceWorkerStatus: 'unsupported',
diff --git a/__tests__/steps/onMarkJourney.spec.ts b/__tests__/steps/onMarkJourney.spec.ts
@@ -40,7 +40,7 @@ describe('markStep', () => {
       markStep('loaded_second_screen_first_journey');
       expect(onMarkStepSpy).toHaveBeenLastCalledWith(
         'loaded_second_screen_first_journey',
-        ['load_second_screen_first_journey'],
+        [],
       );
     });
   });
diff --git a/__tests__/stepsTestConstants.ts b/__tests__/stepsTestConstants.ts
@@ -32,6 +32,10 @@ export const STEP_THRESHOLDS: IStepsThresholds = {
 };
 
 const steps: IStepsConfig = {
+  load_first_screen_first_journey: {
+    threshold: IThresholdTier.unavoidable,
+    marks: ['launch', 'loaded_first_screen_first_journey'],
+  },
   load_second_screen_first_journey: {
     threshold: IThresholdTier.instant,
     marks: [
diff --git a/src/steps/measureStep.ts b/src/steps/measureStep.ts
@@ -2,8 +2,7 @@ import { M, S, WP } from '../constants';
 import { reportPerf } from '../reportPerf';
 import { config } from '../config';
 
-import { STEP_THRESHOLDS } from '../vitalsScore';
-import { getRating } from '../vitalsScore';
+import { STEP_THRESHOLDS, getRating } from '../vitalsScore';
 
 export const measureStep = (
   step: string,
diff --git a/src/steps/measureSteps.ts b/src/steps/measureSteps.ts
@@ -8,10 +8,10 @@ export const measureSteps = (endMark: string) => {
     // this is an end mark so we delete the entry
     const finalSteps = steps.finalMarkToStepsMap[endMark];
     Object.keys(finalSteps).forEach(startMark => {
-      const steps = finalSteps[startMark];
-      steps.forEach(removeActiveStep);
+      const possibleSteps = finalSteps[startMark];
+      possibleSteps.forEach(removeActiveStep);
       Promise.all(
-        steps.map(async step => {
+        possibleSteps.map(async step => {
           // measure
           await measureStep(step, startMark, endMark);
         }),
